Warn on invalid semver (#22)

Co-authored-by: CrazyMax <crazy-max@users.noreply.github.com>
docker · Dec 1, 2020 · 4c2760b · 4c2760b
1 parent ef12c77
commit 4c2760b
Show file tree

Hide file tree

Showing 4 changed files with 38 additions and 2 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -83,9 +83,11 @@ jobs:
   tag-semver:
     runs-on: ubuntu-latest
     steps:
-      - name: Checkout
+      -
+        name: Checkout
         uses: actions/checkout@v2
-      - name: Docker meta
+      -
+        name: Docker meta
         uses: ./
         with:
           images: |

diff --git a/__tests__/meta.test.ts b/__tests__/meta.test.ts
@@ -737,6 +737,32 @@ describe('push tag', () => {
         "org.opencontainers.image.licenses=MIT"
       ]
     ],
+    [
+      'event_tag_sometag.env',
+      {
+        images: ['ghcr.io/user/app'],
+        tagSemver: ['{{version}}', '{{major}}.{{minor}}', '{{major}}'],
+      } as Inputs,
+      {
+        main: 'sometag',
+        partial: [],
+        latest: true
+      } as Version,
+      [
+        'ghcr.io/user/app:sometag',
+        'ghcr.io/user/app:latest',
+      ],
+      [
+        "org.opencontainers.image.title=Hello-World",
+        "org.opencontainers.image.description=This your first repo!",
+        "org.opencontainers.image.url=https://github.com/octocat/Hello-World",
+        "org.opencontainers.image.source=https://github.com/octocat/Hello-World",
+        "org.opencontainers.image.version=sometag",
+        "org.opencontainers.image.created=2020-01-10T00:30:00.000Z",
+        "org.opencontainers.image.revision=90dd6032fac8bda1b6c4436a2e65de27961ed071",
+        "org.opencontainers.image.licenses=MIT"
+      ]
+    ],
   ])('given %p event ', tagsLabelsTest);
 });
 

diff --git a/dist/index.js b/dist/index.js
diff --git a/src/meta.ts b/src/meta.ts
@@ -2,6 +2,7 @@ import * as handlebars from 'handlebars';
 import * as moment from 'moment';
 import * as semver from 'semver';
 import {Inputs} from './context';
+import * as core from '@actions/core';
 import {Context} from '@actions/github/lib/context';
 import {ReposGetResponseData} from '@octokit/types';
 
@@ -46,6 +47,9 @@ export class Meta {
       });
     } else if (/^refs\/tags\//.test(this.context.ref)) {
       version.main = this.context.ref.replace(/^refs\/tags\//g, '').replace(/\//g, '-');
+      if (this.inputs.tagSemver.length > 0 && !semver.valid(version.main)) {
+        core.warning(`${version.main} is not a valid semver. More info: https://semver.org/`);
+      }
       if (this.inputs.tagSemver.length > 0 && semver.valid(version.main)) {
         const sver = semver.parse(version.main, {
           includePrerelease: true