enable comments to avoid breaking change with current impl

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
docker · Jun 13, 2023 · ef7eee9 · ef7eee9
1 parent 8ec80c3
commit ef7eee9
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 5 deletions.
diff --git a/__tests__/context.test.ts b/__tests__/context.test.ts
@@ -63,7 +63,24 @@ describe('getInputs', () => {
         sepTags: ',',
         tags: [],
       } as Inputs
-    ]
+    ],
+    [
+      2,
+      new Map<string, string>([
+        ['images', 'moby/buildkit\n#comment\nghcr.io/moby/mbuildkit'],
+      ]),
+      {
+        context: ContextSource.workflow,
+        bakeTarget: 'docker-metadata-action',
+        flavor: [],
+        githubToken: '',
+        images: ['moby/buildkit', 'ghcr.io/moby/mbuildkit'],
+        labels: [],
+        sepLabels: '\n',
+        sepTags: '\n',
+        tags: [],
+      } as Inputs
+    ],
   ])(
     '[%d] given %p as inputs, returns %p',
     async (num: number, inputs: Map<string, string>, expected: Inputs) => {

diff --git a/src/context.ts b/src/context.ts
@@ -19,10 +19,10 @@ export interface Inputs {
 export function getInputs(): Inputs {
   return {
     context: (core.getInput('context') || ContextSource.workflow) as ContextSource,
-    images: Util.getInputList('images', {ignoreComma: true}),
-    tags: Util.getInputList('tags', {ignoreComma: true}),
-    flavor: Util.getInputList('flavor', {ignoreComma: true}),
-    labels: Util.getInputList('labels', {ignoreComma: true}),
+    images: Util.getInputList('images', {ignoreComma: true, comment: '#'}),
+    tags: Util.getInputList('tags', {ignoreComma: true, comment: '#'}),
+    flavor: Util.getInputList('flavor', {ignoreComma: true, comment: '#'}),
+    labels: Util.getInputList('labels', {ignoreComma: true, comment: '#'}),
     sepTags: core.getInput('sep-tags', {trimWhitespace: false}) || `\n`,
     sepLabels: core.getInput('sep-labels', {trimWhitespace: false}) || `\n`,
     bakeTarget: core.getInput('bake-target') || `docker-metadata-action`,