Skip to content

Commit

Permalink
Improve logging and error handling
Browse files Browse the repository at this point in the history
  • Loading branch information
Michal Dorner committed Jan 18, 2021
1 parent 967dbab commit 1ab5efa
Show file tree
Hide file tree
Showing 7 changed files with 174 additions and 33 deletions.
142 changes: 126 additions & 16 deletions dist/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/index.js.map

Large diffs are not rendered by default.

9 changes: 6 additions & 3 deletions src/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,13 +50,15 @@ async function main(): Promise<void> {
const files = await getFiles(path)

if (files.length === 0) {
core.setFailed(`No file matches path ${path}`)
core.setFailed(`No file matches path '${path}'`)
return
}

core.info(`Using test report parser '${reporter}'`)
const result = await parser(files, opts)
const conclusion = result.success ? 'success' : 'failure'

core.info(`Creating check run '${name}' with conclusion '${conclusion}'`)
await octokit.checks.create({
head_sha: sha,
name,
Expand All @@ -68,7 +70,7 @@ async function main(): Promise<void> {

core.setOutput('conclusion', conclusion)
if (failOnError && !result.success) {
core.setFailed(`Failed test has been found and 'fail-on-error' option is set to ${failOnError}.`)
core.setFailed(`Failed test has been found and 'fail-on-error' option is set to ${failOnError}`)
}
}

Expand All @@ -83,14 +85,15 @@ function getParser(reporter: string): ParseTestResult {
case 'jest-junit':
return parseJestJunit
default:
throw new Error(`Input parameter 'reporter' is set to invalid value '${reporter}'`)
throw new Error(`Input variable 'reporter' is set to invalid value '${reporter}'`)
}
}

export async function getFiles(pattern: string): Promise<FileContent[]> {
const paths = await glob(pattern, {dot: true})
return Promise.all(
paths.map(async path => {
core.info(`Reading test report '${path}'`)
const content = await fs.promises.readFile(path, {encoding: 'utf8'})
return {path, content}
})
Expand Down
18 changes: 16 additions & 2 deletions src/parsers/dart-json/dart-json-parser.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import * as core from '@actions/core'
import {Annotation, FileContent, ParseOptions, TestResult} from '../parser-types'

import getReport from '../../report/get-report'
Expand Down Expand Up @@ -85,8 +86,21 @@ export async function parseDartJson(files: FileContent[], options: ParseOptions)
}

function getTestRun(path: string, content: string): TestRun {
const lines = content.split(/\n\r?/g).filter(line => line !== '')
const events = lines.map(str => JSON.parse(str)) as ReportEvent[]
core.info(`Parsing content of '${path}'`)
const lines = content.split(/\n\r?/g)
const events = lines
.map((str, i) => {
if (str.trim() === '') {
return null
}
try {
return JSON.parse(str)
} catch (e) {
const col = e.columnNumber !== undefined ? `:${e.columnNumber}` : ''
new Error(`Invalid JSON at ${path}:${i + 1}${col}\n\n${e}`)
}
})
.filter(evt => evt != null) as ReportEvent[]

let success = false
let totalTime = 0
Expand Down
18 changes: 12 additions & 6 deletions src/parsers/dotnet-trx/dotnet-trx-parser.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import * as core from '@actions/core'
import {ErrorInfo, Outcome, TestMethod, TrxReport} from './dotnet-trx-types'

import {Annotation, FileContent, ParseOptions, TestResult} from '../parser-types'
Expand Down Expand Up @@ -29,7 +30,7 @@ class Test {
readonly error?: ErrorInfo
) {}

get result(): TestExecutionResult {
get result(): TestExecutionResult | undefined {
switch (this.outcome) {
case 'Passed':
return 'success'
Expand All @@ -46,7 +47,7 @@ export async function parseDotnetTrx(files: FileContent[], options: ParseOptions
const testClasses: TestClass[] = []

for (const file of files) {
const trx = await getTrxReport(file.content)
const trx = await getTrxReport(file)
const tc = getTestClasses(trx)
const tr = getTestRunResult(file.path, trx, tc)
testRuns.push(tr)
Expand All @@ -66,10 +67,15 @@ export async function parseDotnetTrx(files: FileContent[], options: ParseOptions
}
}

async function getTrxReport(content: string): Promise<TrxReport> {
return (await parseStringPromise(content, {
attrValueProcessors: [parseAttribute]
})) as TrxReport
async function getTrxReport(file: FileContent): Promise<TrxReport> {
core.info(`Parsing content of '${file.path}'`)
try {
return (await parseStringPromise(file.content, {
attrValueProcessors: [parseAttribute]
})) as TrxReport
} catch (e) {
throw new Error(`Invalid XML at ${file.path}\n\n${e}`)
}
}

function getTestRunResult(path: string, trx: TrxReport, testClasses: TestClass[]): TestRunResult {
Expand Down
Loading

0 comments on commit 1ab5efa

Please sign in to comment.