Merge pull request #118 from dorny/java-junit-support-errors

Fix JUnit test-cases with error misclassified as passed test
dorny · May 24, 2021 · e8f4fdf · e8f4fdf
2 parents 6969ae6 + d01ef00
commit e8f4fdf
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 12 deletions.
diff --git a/dist/index.js b/dist/index.js
diff --git a/dist/index.js.map b/dist/index.js.map
diff --git a/src/parsers/java-junit/java-junit-parser.ts b/src/parsers/java-junit/java-junit-parser.ts
@@ -107,18 +107,24 @@ export class JavaJunitParser implements TestParser {
   }
 
   private getTestCaseResult(test: TestCase): TestExecutionResult {
-    if (test.failure) return 'failed'
+    if (test.failure || test.error) return 'failed'
     if (test.skipped) return 'skipped'
     return 'success'
   }
 
   private getTestCaseError(tc: TestCase): TestCaseError | undefined {
-    if (!this.options.parseErrors || !tc.failure) {
+    if (!this.options.parseErrors) {
       return undefined
     }
 
-    const failure = tc.failure[0]
-    const details = failure._
+    // We process <error> and <failure> the same way
+    const failures = tc.failure ?? tc.error
+    if (!failures) {
+      return undefined
+    }
+
+    const failure = failures[0]
+    const details = typeof failure === 'object' ? failure._ : failure
     let filePath
     let line
 
@@ -132,7 +138,7 @@ export class JavaJunitParser implements TestParser {
       path: filePath,
       line,
       details,
-      message: failure.message
+      message: typeof failure === 'object' ? failure.message : undefined
     }
   }
 

diff --git a/src/parsers/java-junit/java-junit-types.ts b/src/parsers/java-junit/java-junit-types.ts
@@ -33,7 +33,8 @@ export interface TestCase {
     name: string
     time: string
   }
-  failure?: Failure[]
+  failure?: string | Failure[]
+  error?: string | Failure[]
   skipped?: string[]
 }