Skip to content

Commit

Permalink
Remove start_column from annotation
Browse files Browse the repository at this point in the history
We can't determine end_column
  • Loading branch information
Michal Dorner committed Nov 28, 2020
1 parent fc8cfe0 commit ed138d5
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 7 deletions.
4 changes: 0 additions & 4 deletions __tests__/__snapshots__/jest-junit.test.ts.snap
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ Received: false
at C:\\\\Users\\\\Michal\\\\Workspace\\\\dorny\\\\test-check\\\\reports\\\\jest\\\\node_modules\\\\jest-jasmine2\\\\build\\\\queueRunner.js:75:41
at processTicksAndRejections (internal/process/task_queues.js:97:5)",
"path": "__tests__/main.test.js",
"start_column": 21,
"start_line": 10,
"title": "Exception was thrown here",
},
Expand All @@ -34,7 +33,6 @@ Received: false
at C:\\\\Users\\\\Michal\\\\Workspace\\\\dorny\\\\test-check\\\\reports\\\\jest\\\\node_modules\\\\jest-jasmine2\\\\build\\\\queueRunner.js:75:41
at processTicksAndRejections (internal/process/task_queues.js:97:5)",
"path": "lib/main.js",
"start_column": 9,
"start_line": 2,
"title": "Exception was thrown here",
},
Expand All @@ -50,7 +48,6 @@ Received: false
at C:\\\\Users\\\\Michal\\\\Workspace\\\\dorny\\\\test-check\\\\reports\\\\jest\\\\node_modules\\\\jest-jasmine2\\\\build\\\\queueRunner.js:75:41
at processTicksAndRejections (internal/process/task_queues.js:97:5)",
"path": "__tests__/main.test.js",
"start_column": 11,
"start_line": 21,
"title": "Exception was thrown here",
},
Expand All @@ -72,7 +69,6 @@ Received: false
at runTestInternal (C:\\\\Users\\\\Michal\\\\Workspace\\\\dorny\\\\test-check\\\\reports\\\\jest\\\\node_modules\\\\jest-runner\\\\build\\\\runTest.js:380:22)
at runTest (C:\\\\Users\\\\Michal\\\\Workspace\\\\dorny\\\\test-check\\\\reports\\\\jest\\\\node_modules\\\\jest-runner\\\\build\\\\runTest.js:472:34)",
"path": "__tests__/second.test.js",
"start_column": 34,
"start_line": 1,
"title": "Exception was thrown here",
},
Expand Down
1 change: 0 additions & 1 deletion dist/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/index.js.map

Large diffs are not rendered by default.

1 change: 0 additions & 1 deletion src/parsers/jest-junit/jest-junit-parser.ts
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,6 @@ function getAnnotations(junit: JunitReport, workDir: string, trackedFiles: strin
annotation_level: 'failure',
start_line: src.line,
end_line: src.line,
start_column: src.column,
path: src.file,
message: ex,
title: 'Exception was thrown here'
Expand Down

0 comments on commit ed138d5

Please sign in to comment.