Env var template in signing configuration does not seems to work

goreleaser · May 10, 2020 · 1453233 · 1453233
1 parent c2638bf
commit 1453233
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 10 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -73,7 +73,6 @@ jobs:
           go-version: 1.13
       -
         name: Import GPG key
-        id: import_gpg
         uses: crazy-max/ghaction-import-gpg@v1
         env:
           GPG_PRIVATE_KEY: ${{ secrets.GPG_PRIVATE_KEY_TEST }}
@@ -84,13 +83,9 @@ jobs:
         with:
           version: latest
           args: -f .goreleaser-signing.yml check --debug
-        env:
-          GPG_FINGERPRINT: ${{ steps.import_gpg.outputs.fingerprint }}
       -
         name: GoReleaser
         uses: ./
         with:
           version: latest
           args: -f .goreleaser-signing.yml release --skip-publish --rm-dist
-        env:
-          GPG_FINGERPRINT: ${{ steps.import_gpg.outputs.fingerprint }}
diff --git a/.goreleaser-signing.yml b/.goreleaser-signing.yml
@@ -37,4 +37,4 @@ checksum:
 signs:
   -
     artifacts: checksum
-    args: ["--batch", "-u", "{{ .Env.GPG_FINGERPRINT }}", "--output", "${signature}", "--detach-sign", "${artifact}"]
+    args: ["--batch", "-u", "27571A53B86AF0C799B38BA77D851EB72D73BDA0", "--output", "${signature}", "--detach-sign", "${artifact}"]
diff --git a/README.md b/README.md
@@ -97,7 +97,6 @@ If [signing is enabled](https://goreleaser.com/customization/#Signing) in your G
 ```yaml
       -
         name: Import GPG key
-        id: import_gpg
         uses: crazy-max/ghaction-import-gpg@v1
         env:
           GPG_PRIVATE_KEY: ${{ secrets.GPG_PRIVATE_KEY }}
@@ -110,15 +109,14 @@ If [signing is enabled](https://goreleaser.com/customization/#Signing) in your G
           args: release --rm-dist
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          GPG_FINGERPRINT: ${{ steps.import_gpg.outputs.fingerprint }}
 ```
 
-Reference the fingerprint in your signing configuration using the `GPG_FINGERPRINT` envrionment variable:
+And reference the userID in your signing configuration:
 
 ```yaml
 signs:
   - artifacts: checksum
-    args: ["--batch", "-u", "{{ .Env.GPG_FINGERPRINT }}", "--output", "${signature}", "--detach-sign", "${artifact}"]
+    args: ["--batch", "-u", "<key id, fingerprint, email, ...>", "--output", "${signature}", "--detach-sign", "${artifact}"]
 ```
 
 ## Customizing